fix(librarian): use dynamic year instead of hardcoded 2024/2025#847
Merged
kdcokenny merged 1 commit intocode-yeongyu:devfrom Jan 16, 2026
Merged
fix(librarian): use dynamic year instead of hardcoded 2024/2025#847kdcokenny merged 1 commit intocode-yeongyu:devfrom
kdcokenny merged 1 commit intocode-yeongyu:devfrom
Conversation
Contributor
|
All contributors have signed the CLA. Thank you! ✅ |
There was a problem hiding this comment.
1 issue found across 1 file
Confidence score: 3/5
- Escaped template literal in
src/agents/librarian.tscauses the prompt to show the literal${new Date().getFullYear()}instead of the actual year, so users will see stale text immediately. - This is a concrete behavior regression that should be corrected before merge to avoid confusing users about the date context.
- Pay close attention to
src/agents/librarian.ts- escaped template literal keeps${new Date().getFullYear()}literal.
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="src/agents/librarian.ts">
<violation number="1" location="src/agents/librarian.ts:49">
P2: Escaped template literal prevents dynamic year; prompt contains literal `${new Date().getFullYear()}` text instead of interpolated current year.</violation>
</file>
Since this is your first cubic review, here's how it works:
- cubic automatically reviews your code and comments on bugs and improvements
- Teach cubic by replying to its comments. cubic learns from your replies and gets better over time
- Ask questions if you need clarification on any suggestion
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
1752f28 to
47e64a4
Compare
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
Collaborator
|
Awesome, thanks! |
sssgun
pushed a commit
to sssgun/oh-my-opencode
that referenced
this pull request
Jan 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
${new Date().getFullYear()}calculationChanges
src/agents/librarian.ts: 5 occurrences updated (lines 49, 50, 51, 52, 252)Testing
bun run typecheckpassesbun run buildsucceedsSummary by cubic
Switched the librarian agent’s date guidance to use the current year dynamically instead of hardcoded 2024/2025. This keeps search instructions and “Latest Info” queries up to date automatically.
Written for commit 47e64a4. Summary will update on new commits.